Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Emailrep analyzer #467

Merged
merged 1 commit into from Dec 17, 2019
Merged

add Emailrep analyzer #467

merged 1 commit into from Dec 17, 2019

Conversation

@ninoseki
Copy link
Contributor

ninoseki commented Apr 19, 2019

Implement #466

@3c7 3c7 changed the base branch from develop to release/2.4.0 Dec 17, 2019
@3c7

This comment has been minimized.

Copy link
Member

3c7 commented Dec 17, 2019

Thanks, @ninoseki!

@3c7 3c7 merged commit 56f6141 into TheHive-Project:release/2.4.0 Dec 17, 2019
@ninoseki

This comment has been minimized.

Copy link
Contributor Author

ninoseki commented Dec 19, 2019

@3c7 The API reponse schema of Emailrep has been changed and current implementation does'nt work well.
Should I make a PR to release/2.4.0 to fix the issue?

@3c7

This comment has been minimized.

Copy link
Member

3c7 commented Dec 19, 2019

Hey @ninoseki, that would be great!

@3c7

This comment has been minimized.

Copy link
Member

3c7 commented Dec 19, 2019

I'm reverting the merge for now and you should be able to push the changes directly via this PR.

Edit: okay that's not how github does the revert. So, please, if you could base a new PR on release/2.4.0 that would be great!

@3c7 3c7 added this to the 2.4.0 milestone Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.