Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex logs the Play secret key at startup. #244

Closed
To-om opened this issue Jan 16, 2020 · 0 comments
Closed

Cortex logs the Play secret key at startup. #244

To-om opened this issue Jan 16, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@To-om
Copy link
Contributor

@To-om To-om commented Jan 16, 2020

Request Type

Enhancement

Problem Description

This issue is identical to TheHive-Project/TheHive#1177

At startup, the Docker entrypoint prints the value of play.http.secret.key to stdout, which is commonly logged. This allows anyone with access to the logs to see the key. To practise proper secrets management, this value should not be logged.

Complementary information

By default the secret should not be logged but in case of the secret is randomly generated, it could be interested to get that secret (for debugging purpose). I've added a parameter --show-secret for that.

@To-om To-om added the enhancement label Jan 16, 2020
@To-om To-om added this to the 3.0.1 milestone Jan 16, 2020
@To-om To-om self-assigned this Jan 16, 2020
To-om added a commit that referenced this issue Jan 16, 2020
@To-om To-om closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.