Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Empty Case Button Broken #890

Closed
zpriddy opened this Issue Feb 21, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@zpriddy
Copy link
Contributor

zpriddy commented Feb 21, 2019

Request Type

BUG

Work Environment

Question Answer
TheHive version / git hash 3.3.0-RC3

Problem Description

Enabling Hide Empty Case Button doesn't seem to work. However when trying to click the button hidden selected or not I get the following console error:

vendor.5591ec60.js:6 Error: [$injector:unpr] Unknown provider: aProvider <- a
http://errors.angularjs.org/1.5.8/$injector/unpr?p0=aProvider%20%3C-%20a
    at vendor.5591ec60.js:4
    at vendor.5591ec60.js:5
    at Object.d [as get] (vendor.5591ec60.js:5)
    at vendor.5591ec60.js:5
    at d (vendor.5591ec60.js:5)
    at e (vendor.5591ec60.js:5)
    at Object.g [as invoke] (vendor.5591ec60.js:5)
    at vendor.5591ec60.js:12
    at Object.d [as forEach] (vendor.5591ec60.js:4)
    at Object.resolve (vendor.5591ec60.js:12)

I am not sure if this is a build error or a different problem. I didnt see any errors while building TheHive.

@crackytsi

This comment has been minimized.

Copy link

crackytsi commented Feb 22, 2019

Hi,
Unfortunately I can confirm that.
I installed the standard debian 9 package but after enabling the "Hide Button" the new-case button does not work at all.
So if I try to click on it, there is no reaction and now window is popping up.

regards
Chris

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Feb 22, 2019

Yes I agree, next time I’ll not push code after some glasses of wine ^^

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Feb 22, 2019

We will release a RC4 either today or monday. But now I have to include another gift in it :)

@crackytsi

This comment has been minimized.

Copy link

crackytsi commented Feb 22, 2019

No problem for me. You were so hardworking and if you take on the very long feature-list its impressing.

Everybody should be aware: Its a beta-release so issues should be expected.
I'm happy about your great work!!! :) :)
Hope the wine was good ;)

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Feb 22, 2019

Yes, some angular service injection stuff is not visible in dev mode, so it works in dev but fails on runtime from the built front end.

Thanks for the support @crackytsi

@nadouani nadouani added the bug label Feb 22, 2019

@nadouani nadouani changed the title [BUG] Hide Empty Case Button Broken - 3.3.0-RC3 Hide Empty Case Button Broken Feb 22, 2019

@nadouani nadouani added this to the 3.3.0-RC4 milestone Feb 22, 2019

nadouani added a commit that referenced this issue Feb 22, 2019

@nadouani nadouani closed this Feb 22, 2019

@crackytsi

This comment has been minimized.

Copy link

crackytsi commented Feb 22, 2019

@nadouani Would it make sense not to offer "empty case" if I import an alert to case if this configuration option is set?

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Feb 22, 2019

I've added this already in 3.3 RC4. The only case where Empty Case is possible, independently from the UI Config, is when you don't have any case templates defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.