New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some more functions #96

Merged
merged 4 commits into from Dec 17, 2018

Conversation

Projects
None yet
2 participants
@jojoob
Copy link

jojoob commented Nov 21, 2018

This pull requests adds the following functions:

  • get_case_task(taskId) retrieve a single task by its id
  • get_task_log(attributes) retrieve a single task log by its id
  • delete_case(case_id, force=False) soft/hard delete a case
  • health() retrieve health info
@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Nov 21, 2018

Hello @jojoob, Thanks for the contributions.

TheHive4py is being completely rewritten (take a look to feature/reboot branch).

I could accept these contributions, but once version 2.0 will be released, I think they will be sadly obsolete :(

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Nov 21, 2018

For info: this is the full list of methods that will be provided:

https://github.com/TheHive-Project/TheHive4py/blob/feature/reboot/docs/usage.md

If you have suggestions, about methods that can be added, then please shoot

@nadouani nadouani changed the base branch from master to develop Nov 21, 2018

@jojoob

This comment has been minimized.

Copy link

jojoob commented Nov 21, 2018

@nadouani I know about the ongoing rewrite of TheHive4py and I'm looking glad and impatient forward to its release. ;) Do you have already a planned release date?
Please let me know if you need any help on this.

I extended the current API client because I needed it for a current project I'm working on. So I just wanted to share my work. It's up to you if you want to merge this. I've also two other branches extending the current API...

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Nov 21, 2018

That's cool thanks for the contributions! We will for sure continue maintaining version < 2.0 until everybody move from it.

If you have time, can you give some feedback about 2.0? It's almost release ready, but the documentation is not :(

@jojoob

This comment has been minimized.

Copy link

jojoob commented Nov 21, 2018

Yes, I'll look into 2.0. As soon as I've some time for this I will begin rewriting my application to use TheHive4py 2.0 and post my feedback.

@jojoob jojoob force-pushed the kapschcdc:dev-extend branch from 7e0f15c to f9cc688 Nov 21, 2018

@jojoob

This comment has been minimized.

Copy link

jojoob commented Nov 21, 2018

I changed one commit and rebased the branch because of duplicate find_tasks function.

@nadouani nadouani changed the base branch from develop to 1.x Dec 17, 2018

@nadouani

This comment has been minimized.

Copy link
Contributor

nadouani commented Dec 17, 2018

This PR will be merged into 1.x branch that will be the master branch of version < 2

@nadouani nadouani added this to the 1.6.0 milestone Dec 17, 2018

@nadouani nadouani merged commit 28d30af into TheHive-Project:1.x Dec 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

nadouani added a commit that referenced this pull request Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment