Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coveralls 1.10.0 does not work with coverage 5.0.2 #217

Closed
bcl opened this issue Jan 6, 2020 · 4 comments
Closed

coveralls 1.10.0 does not work with coverage 5.0.2 #217

bcl opened this issue Jan 6, 2020 · 4 comments

Comments

@bcl
Copy link

bcl commented Jan 6, 2020

Travis test run from pykickstart project:

https://travis-ci.org/pykickstart/pykickstart/jobs/633359771

It works fine if I limit coveralls to < 1.10.0 in our requirements.txt, with that it installs:

coverage-4.5.4 coveralls-1.9.2

bcl added a commit to bcl/pykickstart that referenced this issue Jan 6, 2020
Using the current coveralls version (1.10.0) pulls in the latest version
of coverage (5.0.2) and the tests fail because of a missing sqlite
table. Work around this by using the older version of coveralls which
pulls in the older version of coverage.

See: TheKevJames/coveralls-python#217
@agronholm
Copy link

I don't see what this problem has to do with coveralls itself.

@bcl
Copy link
Author

bcl commented Jan 7, 2020

Traceback (most recent call last):

  File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/coverage/sqldata.py", line 1033, in execute

    return self.con.execute(sql, parameters)

sqlite3.OperationalError: no such table: meta

Doesn't happen with 4.5.4, I don't know anything about the internals of coveralls or coverage but it looks like something changed in the 5.x series that coveralls doesn't setup correctly. Or maybe this is a coverage problem?

@agronholm
Copy link

At that point your test suit is not even touching coveralls. Thus, not a coveralls problem. Should be easy to test locally against different version of coverage, yes?

@bcl
Copy link
Author

bcl commented Jan 7, 2020

Thanks, I can reproduce it without coveralls installed at all so it appears to be a coverage issue.

@bcl bcl closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants