Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): reorder configuration precedence #249

Merged
merged 1 commit into from Jan 12, 2021
Merged

Conversation

@TheKevJames
Copy link
Owner

@TheKevJames TheKevJames commented Jan 12, 2021

No description provided.

@TheKevJames TheKevJames force-pushed the config-precedence branch 2 times, most recently from 26e28a9 to 29dce07 Jan 12, 2021
We've been getting a slew of cases where users are reporting requiring
different configurations -- especially Github Actions, where we seem to
need to set a different service name on a case-by-case basis.

Reordering our configuration precedence such that user-specified values
overwrite the CI defaults should allow users to fix these problems
without requiring a one-size-fits-all code change.

This is massively backwards incompatible for anyone with the same key
set to two different values in their configs.
@TheKevJames TheKevJames force-pushed the config-precedence branch from 29dce07 to 66caaa7 Jan 12, 2021
@TheKevJames TheKevJames merged commit f4faa92 into master Jan 12, 2021
26 checks passed
26 checks passed
build (3.5)
Details
build (3.5)
Details
build (3.6)
Details
build (3.6)
Details
build (3.7)
Details
build (3.7)
Details
build (3.8)
Details
build (3.8)
Details
WIP Ready for review
Details
ci/circleci: pre-commit Your tests passed on CircleCI!
Details
ci/circleci: test-py3.5 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.6-cov41 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.6-cov5 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.7-cov41 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.7-cov5 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.8-cov41 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.8-cov5 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.9-alpha-cov41 Your tests passed on CircleCI!
Details
ci/circleci: test-py3.9-alpha-cov5 Your tests passed on CircleCI!
Details
ci/circleci: test-pypy3-5-cov41 Your tests passed on CircleCI!
Details
ci/circleci: test-pypy3-5-cov5 Your tests passed on CircleCI!
Details
ci/circleci: test-pypy3-6-cov41 Your tests passed on CircleCI!
Details
ci/circleci: test-pypy3-6-cov5 Your tests passed on CircleCI!
Details
ci/circleci: test-pypy3-7-cov41 Your tests passed on CircleCI!
Details
ci/circleci: test-pypy3-7-cov5 Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.1%) to 89.003%
Details
@delete-merged-branch delete-merged-branch bot deleted the config-precedence branch Jan 12, 2021
Harmon758 added a commit to Harmon758/tweepy that referenced this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant