Skip to content

Frank Mueller TheMue

Organizations

Juju Tideland
TheMue pushed to master at TheMue/juju
Frank Mueller
  • Juju bot d668b6e
    Merge pull request #294 from TheMue/flakey-test-machine-interfaces-wa…
  • Juju bot f83ce44
    Merge pull request #292 from waigani/imports-cleanup
  • 6 more commits »
TheMue commented on pull request juju/juju#294
Frank Mueller

$$merge$$

Frank Mueller
TheMue opened pull request juju/juju#294
Frank Mueller
Changed to the well known pattern using collect() für multi-events.
1 commit with 56 additions and 32 deletions
TheMue commented on pull request juju/juju#293
Frank Mueller

LGTM, nice work. Only dislike the Get prefix in the network test a bit, but it isn't public, so no problem.

TheMue commented on pull request juju/juju#293
Frank Mueller

Sometimes wishing a kind off tri-state here so that an accessing function can see if it has been initialized. ;)

TheMue pushed to master at TheMue/juju
Frank Mueller
TheMue created branch flakey-tests at TheMue/juju
Frank Mueller
TheMue deleted branch peergrouper-ipv6-testing at TheMue/juju
TheMue pushed to master at TheMue/juju
Frank Mueller
TheMue commented on pull request juju/names#13
Frank Mueller

LGTM

TheMue commented on pull request juju/juju#281
Frank Mueller

$$merge$$

Frank Mueller
TheMue commented on commit TheMue/juju@4c8c7611d7
Frank Mueller

Oh, indeed, missed it. It seems the peergrouper has no problem with mixed internet stacks. Interesting.

TheMue commented on pull request juju/juju#281
Frank Mueller

Changed, ready for the next review.

Frank Mueller
TheMue created tag juju-1.20.1 at TheMue/juju
TheMue commented on pull request juju/juju#281
Frank Mueller

Done.

TheMue commented on pull request juju/juju#281
Frank Mueller

Done.

TheMue commented on pull request juju/juju#281
Frank Mueller

It's now a struct containing all needed information.

TheMue commented on pull request juju/juju#281
Frank Mueller

Done.

TheMue commented on pull request juju/juju#281
Frank Mueller

Thanks for the good ideas, will change it.

Frank Mueller
  • Frank Mueller a3bfd0b
    gont/web: added options and some convenience
TheMue opened pull request juju/juju#281
Frank Mueller
Added testing for IPv6 to peer grouper tests
2 commits with 623 additions and 402 deletions
TheMue commented on pull request juju/juju#279
Frank Mueller

LGTM

TheMue commented on pull request juju/charm#15
Frank Mueller

LGTM

TheMue commented on pull request juju/charm#13
Frank Mueller

LGTM

Something went wrong with that request. Please try again.