Project+Tests: Added/tweaked various game files #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOnlyZac
changed the title
detolly
requested changes
Nov 25, 2021
src/cheats.cpp
Outdated
| @@ -5,31 +5,32 @@ | |||
| #include <cstring> | |||
| #include <iostream> | |||
|
|
|||
| char chetkido_ciphertext[] = "@KFWHJGL"; | |||
| char s_the_password_is[] = "The password is: "; | |||
| char chetkido_buffer[64]; | |||
There was a problem hiding this comment.
Is this not a stack allocated buffer?
There was a problem hiding this comment.
I'm not sure I understand the question
TheOnlyZac
changed the title
TheOnlyZac
changed the title
detolly
requested changes
Nov 29, 2021
VelocityRa
reviewed
Nov 29, 2021
There was a problem hiding this comment.
No need to spend all that time on tests, imo. Gonna take way too long this way.
And you could still miss things. Might wanna work on infrastructure/tooling for function replacement patches & test the game this way instead (the method we were talking about with @detolly).
It will not be easy but I don't see the current method scaling up well at all.
detolly
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.