Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of i18n #79 #129

Merged
merged 2 commits into from Sep 19, 2019

Conversation

@motchie
Copy link
Contributor

motchie commented Sep 10, 2019

Enhancement of i18n

Hi,
This is my experimental implementation of i18n.

I referred to past issue #79 comment.
#79 (comment)

Here is my PR's policy.

do electron apps pick up the user's operating system locale (e.g. to check which language the OS is set to)?

Possible. I adopted Locales API of electron.

splitting out all strings into separate language/translation files (so no actual strings are hard-coded into the html/js, but it's all handled by grabbing strings from a language file

I think it's possible like Version Number implementation, but this time I adopted more simpe policy. Which is:

  • Splitting out all strings into language files.
  • Language files are auto detected. When missing, it's fall back to English.
  • In English, Nothing has changed in the UI.
  • No modification to original HTML.
  • changes in controller/js is minimum.
  • All translations are executed in view/js with label and replace() .

providing options/settings for users to change the language (so they can set it to something other than the OS locale if they wish)

No implementation yet.
If PR is adopted, I would like to enhance it.

Example Screenshot

ScreenShot of Japanse version of CCA.

Environment

This is my development environment.

  • OS: Darwin x64 18.7.0
  • Visual Studio Code: 1.38.0
  • last commit: c8ece59
@ferllings

This comment has been minimized.

Copy link
Member

ferllings commented Sep 11, 2019

Thanks for all your PRs. I'll try to review them asap.

@ferllings ferllings merged commit 53dda11 into ThePacielloGroup:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.