Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix thumbnails sometimes not being resized in the save browser
This was because ImageRequest::Finish used its Width and Height members after calling Request::Finish, after which the ImageRequest object may get deleted at any time by RequestManager. One solution to this is to copy (or preferably move) important members to local variables in the Finish functions of objects derived from Request and use only those after calling Request::Finish (or anything that in turn calls that).
- Loading branch information
Showing
4 changed files
with
15 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters