Permalink
Browse files

Moving conditional branches around

  • Loading branch information...
LBPHacker authored and jacob1 committed May 5, 2017
1 parent ce054bf commit e15bfac60f930877c940cac5662ceacc7e0f4826
Showing with 13 additions and 18 deletions.
  1. +13 −18 src/gui/game/PropertyTool.cpp
@@ -122,27 +122,14 @@ void PropertyWindow::SetProperty()
}
else
{
if(properties[property->GetOption().second].Type == StructProperty::ParticleType)
int type;
if (properties[property->GetOption().second].Type == StructProperty::ParticleType && (type = sim->GetParticleType(value)) != -1)
{
int type = sim->GetParticleType(value);
if(type != -1)
{
v = type;
#ifdef DEBUG
std::cout << "Got type from particle name" << std::endl;
std::cout << "Got type from particle name" << std::endl;
#endif
v = type;
}
else
{
std::stringstream buffer(value);
buffer.exceptions(std::stringstream::failbit | std::stringstream::badbit);
buffer >> v;
}
if (property->GetOption().first == "type" && (v < 0 || v >= PT_NUM || !sim->elements[v].Enabled))
{
new ErrorMessage("Could not set property", "Invalid particle type");
return;
}
}
else
{
@@ -151,9 +138,17 @@ void PropertyWindow::SetProperty()
buffer >> v;
}
}
if (properties[property->GetOption().second].Type == StructProperty::ParticleType && (v < 0 || v >= PT_NUM || !sim->elements[v].Enabled))
{
new ErrorMessage("Could not set property", "Invalid particle type");
return;
}
#ifdef DEBUG
std::cout << "Got int value " << v << std::endl;
#endif
tool->propValue.Integer = v;
break;
}

0 comments on commit e15bfac

Please sign in to comment.