Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Link Is Clunky #19

Closed
jrg94 opened this issue Jul 17, 2021 · 1 comment · Fixed by #28
Closed

Verify Link Is Clunky #19

jrg94 opened this issue Jul 17, 2021 · 1 comment · Fixed by #28
Assignees
@jrg94
Labels
bug Something isn't working

Comments

@jrg94
Copy link
Member

jrg94 commented Jul 17, 2021

When I exposed Verify Link in 0.2.0, I figured that would make life easier, but it introduces a new problem. The text of the InlineText object needs to be set before the URL can be tested. This isn't a problem necessarily, but if the text is dependent on the URL existing, then you'll have to create a separate InlineText object (or update the existing one).

I'm not sure there is anything to rework here as there may just need to be a pattern defined when this types of situations arise.
@jrg94 jrg94 self-assigned this Jul 17, 2021
@jrg94 jrg94 added the bug Something isn't working label Jul 17, 2021
@jrg94
Copy link
Member Author

jrg94 commented Jul 20, 2021

I'm wondering if adding an update_url function would be better.

@jrg94 jrg94 mentioned this issue Jul 20, 2021
Closed
@jrg94 jrg94 linked a pull request Jul 21, 2021 that will close this issue
Upgrade SnakeMD to 0.5.0 #28
Merged
@jrg94 jrg94 closed this as completed in #28 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrg94 jrg94

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade SnakeMD to 0.5.0 TheRenegadeCoder/SnakeMD
1 participant
@jrg94