Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links Cannot Be Added Within Strings #23

Closed
jrg94 opened this issue Jul 19, 2021 · 1 comment · Fixed by #24
Closed

Links Cannot Be Added Within Strings #23

jrg94 opened this issue Jul 19, 2021 · 1 comment · Fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@jrg94
Copy link
Member

jrg94 commented Jul 19, 2021

We ran into this issue with punctuation (#18), and I'm realizing that this issue is bigger than I thought. I'm not sure how to solve this at the moment, but something to think about for sure. The particular issue that I'm noticing is that we can't even embed links in the middle of structures. For example, I can't do this with SnakeMD:

[[Link](https://test.com)]

This will render with spaces on either end as follows:

[ [Link](https://test.com) ]

This turned out to be the same issue we were having with punctuation, and I already didn't like the regex then.

@jrg94 jrg94 self-assigned this Jul 19, 2021
@jrg94 jrg94 added the bug Something isn't working label Jul 19, 2021
@jrg94
Copy link
Member Author

jrg94 commented Jul 20, 2021

Alright, in v0.4.0, I'm have fixed this by removing the automatic spaces between InlineText objects in paragraphs. The user will be responsible for formatting their strings correctly (e.g., leaving a space at the end of the previous string).

@jrg94 jrg94 linked a pull request Jul 20, 2021 that will close this issue
@jrg94 jrg94 closed this as completed in #24 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant