Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python Matrix of Version Testing #50

Merged
merged 5 commits into from Dec 15, 2021
Merged

Added Python Matrix of Version Testing #50

merged 5 commits into from Dec 15, 2021

Conversation

jrg94
Copy link
Member

@jrg94 jrg94 commented Dec 15, 2021

The goal of this will be to pin down exactly which versions of Python can be used with SnakeMD.

@jrg94 jrg94 requested a review from a team December 15, 2021 22:04
@jrg94 jrg94 self-assigned this Dec 15, 2021
@jrg94 jrg94 added the enhancement New feature or request label Dec 15, 2021
@jrg94 jrg94 linked an issue Dec 15, 2021 that may be closed by this pull request
@jrg94 jrg94 changed the title Added Python Matrix of Testing Added Python Matrix of Version Testing Dec 15, 2021
@jrg94
Copy link
Member Author

jrg94 commented Dec 15, 2021

Looks like 3.6 and 3.7 fail, so we'll restrict the library to 3.8 and 3.9.

@jrg94
Copy link
Member Author

jrg94 commented Dec 15, 2021

Makes sense given that we use the walrus operator in a few places. That's new as of 3.8.

@jrg94 jrg94 marked this pull request as ready for review December 15, 2021 22:12
@jrg94 jrg94 merged commit ea42400 into main Dec 15, 2021
@jrg94 jrg94 deleted the testing branch December 15, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python Version Testing
1 participant