Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-1686 item logging #503

Merged
merged 5 commits into from Oct 19, 2022
Merged

RES-1686 item logging #503

merged 5 commits into from Oct 19, 2022

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented May 18, 2022

Various aspects to this:

  1. Show the devices section on the event page unconditionally.
  2. Fix the statusCount method to only return info from past events. This is used for some stats on the groups page, though the method probably ought to be replaced by something better.
  3. Always return the device information on the event page, via a parameter to the stats which indicates whether or not we want to include future.
  4. Remove the hack about when an event starts.
  5. Test.

@edwh edwh requested a review from restart-neil May 18, 2022 11:06
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edwh
Merge branch 'develop' into RES-1686_item_logging
2253bf1 
# Conflicts:
#	app/Http/Controllers/PartyController.php
@edwh
Merging.
ca5cda6
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edwh edwh merged commit a49ad1e into develop Oct 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngm ngm ngm approved these changes

@restart-neil restart-neil Awaiting requested review from restart-neil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edwh @ngm