RES 1842 reduce N+1 queries #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/Http/Controllers/PartyController.php
|
Kudos, SonarCloud Quality Gate passed!
|
ngm
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
So it looks like everywhere(?) that we query on groups, we now also eagerly fetch the info about networks in. To avoid that query on the networks running for every group, each time we iterate through a list of groups.
Seems good, I suppose we might to think about it if for example networks themselves ever started eagerly fetching things as well, I guess you can get to a point where you end up pulling the whole DB if you're not careful.
Nice to cache the roles table as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now usefully spotted by Sentry. Add some uses of
with()and caching to reduce database queries.