Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-1853 Calculate the number of hours volunteered based on event length #626

Merged
merged 7 commits into from Apr 5, 2023
Merged

RES-1853 Calculate the number of hours volunteered based on event length #626

merged 7 commits into from Apr 5, 2023

Conversation

edwh
Copy link
Collaborator

@edwh edwh commented Mar 10, 2023

This currently includes a script to calculate changes. We'd probably not release this as it stands, just the small change to the calculation.

@edwh edwh requested a review from restart-neil March 10, 2023 13:26
ngm
ngm approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@ngm ngm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good 👍 As you say, for release we'd remove the new/old versions of the calc.

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edwh edwh merged commit 95a280f into develop Apr 5, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngm ngm ngm approved these changes

@restart-neil restart-neil Awaiting requested review from restart-neil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edwh @ngm