New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-1867 Allow restarters to create groups #631

Merged

ngm merged 3 commits into develop from RES-1867_create_group_without_skills

Apr 17, 2023

Collaborator

edwh commented Mar 23, 2023

Restarters should be able to create groups. Allow them to do so, and promote to a host if required.


          Allow restarters to create groups.

4fc2885

edwh requested a review from restart-neil

March 23, 2023 14:23

github-advanced-security bot commented Mar 23, 2023

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

ngm requested changes

View reviewed changes

Contributor

ngm left a comment

The change to the permissions look good as to who can create a group via the API and in the controller.

However, I think a corresponding change is needed in the view - I tested as a new Restarter, and couldn't see a button for creating a group, I'd expect it to be somewhere near the arrow:

edwh added 2 commits

March 31, 2023 11:25


          Button to create a group should show.

f7143b3


          Test fixes.

9baf87d

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

ngm approved these changes

View reviewed changes

ngm merged commit 385b9c6 into develop

3 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment