Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the pokemon search #9

Closed
TheShiveshNetwork opened this issue Oct 15, 2023 · 2 comments · Fixed by #13
Closed

Improve the pokemon search #9

TheShiveshNetwork opened this issue Oct 15, 2023 · 2 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TheShiveshNetwork
Copy link
Owner

What does this issue mean?

Currently the search works on only the rendered pokemon cards. It should search in the whole pokemon response.

Steps to fix the issue

  • Use the pokeapi to get all the pokemons and filter for the searched keyword in pokemon name
  • Display the filtered pokemon cards
  • Optimize the code. It should not have multiple api calls that slow down the app.

How to contribute

If you are interested, reply below and I'll assign this to you.

  • Create a PR
  • Submit and wait for response
  • If the PR is reviewed, it wil be merged

Happy Hacking !!!

@TheShiveshNetwork TheShiveshNetwork added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2023
@Namatuzio
Copy link
Contributor

Hi, I'd like to work on this.

@TheShiveshNetwork
Copy link
Owner Author

@Namatuzio go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants