Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Material related bugs #19

Merged
merged 3 commits into from Mar 22, 2020
Merged

Fix Material related bugs #19

merged 3 commits into from Mar 22, 2020

Conversation

@Chocohead
Copy link
Contributor

Chocohead commented Mar 22, 2020

There are a lot of direct calls to Block#getMaterial(IBlockState) which should be IBlockState#getMaterial() instead. These can cause issues in other mods when null is incorrectly passed.

Also simplifies the portal blocks to share the same placer logic when it only differs on the portal blocks rather than duplicating it.

@TheSlayerMC TheSlayerMC merged commit 1219c5d into TheSlayerMC:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.