Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't have sidebar closed #6

Closed
franciscolourenco opened this issue Apr 29, 2012 · 14 comments
Closed

Can't have sidebar closed #6

franciscolourenco opened this issue Apr 29, 2012 · 14 comments

Comments

@franciscolourenco
Copy link

Having SyncedSideBar installed, it's impossible to have the sidebar closed.
Whenever a file view is changed, the sidebar opens automatically.

@TheSpyder
Copy link
Owner

I see what you mean, but there doesn't appear to be a way for the plugin to determine if the sidebar is visible before running the "reveal active file" command. We'd have to request a new API for that.

@tnorthcutt
Copy link

I also noticed this problem, FWIW. I can hide the sidebar, but as soon as I alt+tab away and back again, it's visible.

@helderco
Copy link

It would be great if this could be solved. I like the package, but can't use it like this.

@calumbrodie
Copy link

+1 - I've had to disable this package for this reason.

@TheSpyder
Copy link
Owner

I've just fixed the bug in disabling the plugin per-project (see #2, #9) which makes this a little bit better.

I took another look through the sublime docs and there's still no sidebar API. If you'd like to help request one, vote for this request.

@LeonardoGentile
Copy link

+1 have the same problem

@barberdt
Copy link

Certainly a deal-breaker for me. :(

@TheSpyder
Copy link
Owner

So vote for it on userecho! I really would like to fix this one, but it's just not possible yet.

@colin-jack
Copy link

Deal breaker for me too.

@a-chernykh
Copy link

+1

@chbrown
Copy link

chbrown commented Dec 15, 2012

+1, voted on userecho

@TheSpyder
Copy link
Owner

Oops, didn't think github would auto close the issue.

The good news is that sublime text 3 added an API that I can hook into for tracking sidebar visibility. It currently has two drawbacks:

  • It only lets me know that a toggle happened, not whether the sidebar was hidden or shown, so the plugin has to force each new window to show the sidebar at first and then track toggles
  • The API only triggers when using the keyboard shortcut, not the menu (I plan to log a bug about that) so if you use the menu the toggle tracking will get out of sync.

The good news is that I was able to add some smarts so if you're like me and use multiple sublime windows, the plugin will track sidebar visibility separately for each window :)

The v3 API is a new event listener - in my testing even through the plugin includes v3 code, v2 simply ignores the extra code and works as it always has. There shouldn't be any adverse affects from this, but if one turns up I'll move the code to a branch.

@TheSpyder TheSpyder reopened this Mar 4, 2013
@TheSpyder
Copy link
Owner

Also, this all requires build 3013, where the on_window_command listener was added. It's only available in a development build as I write this.

@TheSpyder
Copy link
Owner

Build 3025 was released today, which fixes the second of the two issues. It's not perfect, but it is now quite easy to use this plugin with the sidebar closed.

I'll keep an eye out for future APIs that make it 100% reliable but I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants