bugfix(lan): Always allow players to join a LAN room if there is an open slot #1637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where players cannot join a LAN room if the current player count, minus any observers, is greater than or equal to the number of player spawn positions on the selected map. The selected map should have no influence on whether players can join the room.
Example 1: A room with a 2-player map and 2 players has a 3rd open slot - nobody can join unless one of the players is an observer.
Example 2: A room with a 6-player map and 6 players has a 7th and 8th open slot - a 7th player cannot join unless one player is an observer, and an 8th player cannot join unless two players are an observer.