Skip to content

Conversation

@Stubbjax
Copy link

@Stubbjax Stubbjax commented Sep 26, 2025

This change fixes an issue where players cannot join a LAN room if the current player count, minus any observers, is greater than or equal to the number of player spawn positions on the selected map. The selected map should have no influence on whether players can join the room.

Example 1: A room with a 2-player map and 2 players has a 3rd open slot - nobody can join unless one of the players is an observer.

Example 2: A room with a 6-player map and 6 players has a 7th and 8th open slot - a 7th player cannot join unless one player is an observer, and an 8th player cannot join unless two players are an observer.

@Stubbjax Stubbjax self-assigned this Sep 26, 2025
@Stubbjax Stubbjax added Bug Something is not working right, typically is user facing Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Sep 26, 2025
@xezon xezon added Major Severity: Minor < Major < Critical < Blocker and removed Minor Severity: Minor < Major < Critical < Blocker labels Sep 26, 2025
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Can add a comment above the function that highlights that players can now join open slots regardless of starting spots on the map.

@Mauller
Copy link

Mauller commented Sep 26, 2025

Have you tested what affect this has if you start a game with more players in the lobby than spots on the map?

@Stubbjax
Copy link
Author

Have you tested what affect this has if you start a game with more players in the lobby than spots on the map?

The game won't let you start a match if there are more (non-observer) players in the room than map positions.

@xezon xezon changed the title bugfix: Always allow players to join a LAN room if there is an open slot bugfix(lan): Always allow players to join a LAN room if there is an open slot Sep 30, 2025
@xezon xezon merged commit 9174d63 into TheSuperHackers:main Sep 30, 2025
18 checks passed
@Stubbjax Stubbjax deleted the fix-full-lan-room-conditions branch September 30, 2025 22:41
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something is not working right, typically is user facing Gen Relates to Generals Major Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants