fix: crash when replay file is deleted during version mismatch prompt #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

bobtista wants to merge 2 commits into TheSuperHackers:main from bobtista:bobtista/fix-replay-deletion-crash

+36 −2

bobtista commented Nov 12, 2025

Fixes Deleting a replay during the compatibility prompt leads to a crash #1732

TODO

Testing

Testing

Reproduction steps verified:

Select a replay with different executable hash/version
Double-click or press Load button
While version mismatch prompt is visible, delete the replay file externally
Click OK on the prompt
Should show error message instead of crashing

bobtista added 2 commits

November 11, 2025 23:03


          Validate replay file exists before attempting playback in version mis…

bf32f04

…match callback


          Delay playback mode assignment until after replay file opens successf…

66502a8

…ully

bobtista self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet