New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port parameters to quick-start.md #277

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@daveio

daveio commented Nov 12, 2018

The docs as presented didn't match up with the examples, as they assume port 1 rather than the default of port 0.

Add port parameters to quick-start.md
The docs as presented didn't match up with the examples, as they assume port 1 rather than the default of port 0.
@CLAassistant

This comment has been minimized.

CLAassistant commented Nov 12, 2018

CLA assistant check
All committers have signed the CLA.

@johanstokking

This comment has been minimized.

Member

johanstokking commented Nov 12, 2018

I am quite sure that we use port 1 if nothing (or 0) is specified, as FPort 0 is invalid for application payload.

@johanstokking johanstokking requested a review from htdvisser Nov 12, 2018

@daveio

This comment has been minimized.

daveio commented Nov 12, 2018

I am quite sure that we use port 1 if nothing (or 0) is specified, as FPort 0 is invalid for application payload.

Possibly a larger issue then, as

screenshot 2018-11-12 16 52 30

(command in lower pane results in message in upper pane, ttnpub is just a mosquitto_pub $PARAMS alias)

@htdvisser

This comment has been minimized.

Member

htdvisser commented Nov 13, 2018

The logic in v2 is as follows:

  • FPort is set to application-chosen FPort if non-zero
  • FPort is set to FPort of uplink if non-zero
  • FPort is set to 1

The "port" field in the event message that you're receiving on MQTT should have been omitted, and can be ignored until this is fixed (if we actually decide to fix this for v2)

@johanstokking

This comment has been minimized.

Member

johanstokking commented Nov 13, 2018

@daveio can you file a PR on TheThingsNetwork/ttn to tag port with omitempty to avoid the confusion?

@daveio daveio deleted the daveio:patch-1 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment