Skip to content

Create gateway API key modal#7612

Merged
PavelJankoski merged 7 commits into
v3.34from
feature/simplify-create-api-key
May 8, 2025
Merged

Create gateway API key modal#7612
PavelJankoski merged 7 commits into
v3.34from
feature/simplify-create-api-key

Conversation

@PavelJankoski
Copy link
Copy Markdown
Contributor

Summary

References #6697

Changes

  • Added new button in gateway overview subheader.
  • New modal when clicking on the newly added button.
  • Cover new scenario with e2e tests.

Testing

Steps
  1. Login to console.
  2. Go to gateways section.
  3. Select a gateway.
  4. New + API key button should be present in the subheader of the gateway overview.
  5. New modal should be opened.
  6. Try to create API key.
Results

image

image

image

image

image

Notes for Reviewers

I added scrollbar in the rights form field if there are two many options and/or small screen (this may be subject to change in the future)

image

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski requested a review from ryaplots April 30, 2025 14:40
@PavelJankoski PavelJankoski self-assigned this Apr 30, 2025
@PavelJankoski PavelJankoski requested a review from a team as a code owner April 30, 2025 14:40
@PavelJankoski PavelJankoski force-pushed the feature/simplify-create-api-key branch from 0faaaa3 to b8c52c2 Compare April 30, 2025 14:43
@github-actions github-actions Bot added the ui/web This is related to a web interface label Apr 30, 2025
@KrishnaIyer
Copy link
Copy Markdown
Member

This is really nice @PavelJankoski! Good stuff

Copy link
Copy Markdown
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Here are some comments

Comment thread pkg/webui/components/rights-group-modal/index.js Outdated
Comment thread pkg/webui/components/rights-group-modal/index.js
Comment thread pkg/webui/console/containers/api-key-modal-form/create.js Outdated
Comment thread pkg/webui/console/containers/api-key-modal-form/create.js Outdated
@PavelJankoski PavelJankoski force-pushed the feature/simplify-create-api-key branch from d75e54e to 90cdaea Compare May 7, 2025 17:35
@PavelJankoski PavelJankoski requested a review from ryaplots May 7, 2025 17:36
@PavelJankoski PavelJankoski merged commit ed15561 into v3.34 May 8, 2025
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the feature/simplify-create-api-key branch May 8, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants