This repository has been archived by the owner. It is now read-only.
Refactor for Python3 (#28091) #23
Open
Conversation
nmathewson
reviewed
Jan 23, 2019
I've noted a few small issues in the python3 commit on this branch.
| tb_version_config.read(tb_version_path) | ||
| tb_version = tb_version_config['version']['current'] | ||
|
|
||
| except: |
Let's not do an unconditional except: -- instead, let's catch specific exceptions.
| print 'Go to the following link in your browser: ' + authorize_url | ||
| code = raw_input('Enter verification code: ').strip() | ||
| print('Go to the following link in your browser: ' + authorize_url) | ||
| code = input('Enter verification code: ').strip() |
Should this be using getpass() instead?
| @@ -279,7 +279,7 @@ def get_files_links(service, v): | |||
| p3 = re.compile('.*\.dmg$') | |||
| p4 = re.compile('.*\.asc$') | |||
|
|
|||
| for file in uploaded_files.keys(): | |||
| for file in list(uploaded_files.keys()): | |||
Can't this just become for file in uploaded_files: ?
| @@ -153,7 +153,7 @@ def is_json(my_json): | |||
| """Check if json generated is valid.""" | |||
| try: | |||
| json_object = json.loads(my_json) | |||
| except ValueError, e: | |||
| except ValueError as e: | |||
Here (and elsewhere) it looks like you're ignoring the value of the exception -- you can just delete the as e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://bugs.torproject.org/28091
(this lists all commits from https://gitweb.torproject.org/gettor.git since 2017 - reviewing should be easier pulling it in first)
The text was updated successfully, but these errors were encountered: