Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My contributions to #30 #33

Merged
merged 4 commits into from Feb 15, 2017
Merged

My contributions to #30 #33

merged 4 commits into from Feb 15, 2017

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Feb 15, 2017

xref: #31

@hellais
Copy link
Contributor

hellais commented Feb 15, 2017

I think the imports are missing

@hellais
Copy link
Contributor

hellais commented Feb 15, 2017

I will add them in merge.

Thanks!

@hellais hellais merged commit 0bd46ee into feature/intl Feb 15, 2017
@hellais hellais deleted the feature/intl_sbs branch February 15, 2017 23:10
@bassosimone
Copy link
Contributor Author

Oh, sorry, I guess I missed this part:

Check if FormattedMessage is being imported. If it's not add the line:

import { FormattedMessage } from 'react-intl'

@hellais
Copy link
Contributor

hellais commented Feb 15, 2017

It seems like you also used defaultValue instead of defaultMessage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants