From 2c609529b7fdee4a81835ea44dadf668845bae77 Mon Sep 17 00:00:00 2001 From: Pascal Lamblin Date: Thu, 14 Feb 2013 15:09:26 -0500 Subject: [PATCH] Update comment after code review. --- theano/misc/windows.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/theano/misc/windows.py b/theano/misc/windows.py index b9416292686..077c8bffb7f 100644 --- a/theano/misc/windows.py +++ b/theano/misc/windows.py @@ -14,8 +14,12 @@ def call_subprocess_Popen(command, **params): except AttributeError: startupinfo.dwFlags |= subprocess._subprocess.STARTF_USESHOWWINDOW - # Under Windows 7 64-bits, Anaconda's g++ is not found unless - # specifying "shell=True". + # Anaconda for Windows does not always provide .exe files + # in the PATH, they also have .bat files that call the corresponding + # executable. For instance, "g++.bat" is in the PATH, not "g++.exe" + # Unless "shell=True", "g++.bat" is not executed when trying to + # execute "g++" without extensions. + # (Executing "g++.bat" explicitly would also work.) params['shell'] = True proc = subprocess.Popen(command, startupinfo=startupinfo, **params) return proc