use twice Lop to get Rop by default #6037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nouiz
reviewed
Jun 13, 2017
| else: | ||
| raise NotImplementedError( | ||
| "%s of class %s do not have grad or L_op implementation." | ||
| "If this is theano Op, mail to theano-dev mailing list for assistance." |
| outputs = self.make_node(inputs).outputs | ||
| lop_inputs = [o.type() for o in outputs] | ||
| lop_outputs = self.L_op(inputs, outputs, lop_inputs) | ||
| return theano.Lop(lop_outputs, lop_inputs, eval_points) |
There was a problem hiding this comment.
This would need some tests to be sure we don't break it.
It could be a simple test that create a new op with Lop implemented, but not Rop and make sure we can take the Rop. This new Op could inherit from an existing op and delete the Rop method.
|
I would actually suggest to possibly add a test, where you go loop to all implemented ops and if they implement Rop you verify that this gives the same result and the standard Rop. |
|
Agreed with @botev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR for #6035