Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] wp-shortcode decode inside editor in theme settings issue #3061

Closed
danyj opened this issue Dec 5, 2017 · 16 comments

Comments

@danyj
Copy link
Contributor

commented Dec 5, 2017

Worked in previous version , updated to latest master

screenshot_1

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2017

It also happens right after you click on any Unyson shortcode from editor

@ViorelEremia

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2017

I tested it right now, but this is not happening to me. Some details?

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

add this in theme settings option


	'main' => array(
		'title'   => false,
		'type'    => 'box',
		'options' => array(
			'test-addable-vc' => array(
				'type' => 'addable-popup',
				'value' => array(),
				'label' => __('Addable Popup', '{domain}'),
				'template' => '{{- option_1 }}',
				'popup-title' => null,
				'size' => 'small', // small, medium, large
				'limit' => 0, // limit the number of popup`s that can be added
				'add-button-text' => __('Add', '{domain}'),
				'sortable' => true,
				'popup-options' => array(
					'option_1' => array(
							'type' => 'wp-editor',
							'size' => 'large',
							'editor_height' => 200,
							'shortcodes' => true,
							'editor_type' => 'tinymce',
							'wpautop' => false,
							'label' => __('Content', 'creatus'),
							'desc' => esc_html__('Enter some content for this text block', 'creatus'),
							'value' => 'Praesent ut accumsan est. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Cras volutpat, ligula quis mollis elementum, ex nisi interdum ante, eu posuere sem sem et tortor.'
					),

				),
			)
		),
	),

click on add popup ,

in popup editor find Unyson shortcode button
open shortcodes
click on any of them ,
bug is in console

http://prntscr.com/hn02yh

@ViorelEremia

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2017

it is working. I saved, refresh, add new shortcodes save refresh.

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

no js bugs while adding?

@ViorelEremia

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2017

no

@ViorelEremia

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2017

is it happening with other shortcode?

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

all of shortcodes ,

latest wp-editor option, let me update the option again i might have missed something

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

ok false alarm , I must have missed a script, re-downloaded and works, sorry for the trouble

@danyj danyj closed this Dec 13, 2017
@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

sorry mate , is still there , I had console off ,
bug is there for me , now I did not pull shortcode extension if that has something to do with it since it

@danyj danyj reopened this Dec 13, 2017
@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2017

and I see no updates to the extension https://github.com/ThemeFuse/Unyson-WP-Shortcodes-Extension

@ViorelEremia

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2017

I tested(both versions of extension) with the core and scratch and i don't see that.

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

hm , il try to trace it but all I can see is that is going back to this line
https://github.com/ThemeFuse/Unyson-WP-Shortcodes-Extension/blob/master/static/js/plugin.js#L178

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

ok i dont know what this is but files are mismatched ,

I deleted the wp-shortcodes via unyson and downloaded and activated again
what I see on line 303 http://prntscr.com/hnezby

is on line 316

https://github.com/ThemeFuse/Unyson-WP-Shortcodes-Extension/blob/master/static/js/plugin.js#L316

I cleared cache several times
than I deleted Unyson completely

installed again
than had to get the wp-editor from git since the one delivered has a bug
and the error is now back again , line 303 on the mismatched file

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

@danyj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

@andreiglingeanu

Several bugs with the wp-shortocode

it is looking for some depenedncies ,

here is the issue ,
use this file as settings.php

https://gist.github.com/danyj/6a97d703d9083d3a3b9685b97fc49c2e#file-settings-php

for scratch-parent

in option add popup , and try what you did , you will see the bug

issue 2:

use icon as shortcode image , once the popup opens , the wp-shortcodes will look for image instead of icon you set in shortcode config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.