Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svgs in icon v2 #3127

Merged
merged 2 commits into from Jan 16, 2018

Conversation

@andreiglingeanu
Copy link
Collaborator

commented Jan 16, 2018

This PR will fix SVG display & preview in icon-v2 option type. Implements #3089 properly.

cc. @danyj @ViorelEremia

To test:

  1. Put an array('type' => 'icon-v2')
  2. Insert an SVG file into the custom upload tab
  3. see it has a proper preview
@andreiglingeanu andreiglingeanu self-assigned this Jan 16, 2018
@andreiglingeanu andreiglingeanu merged commit 60ad08d into master Jan 16, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.