New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed radio buttons & text-edit cursor appearing on non-editable text. #41

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@niall-slater
Contributor

niall-slater commented Dec 6, 2017

I set them to be radio buttons rather than checkboxes and game them each the same 'name' attribute (to put them in a radio group), and a 'value' attribute (which, judging from options.js, you don't have to use). You can now only select one of them at a time.

I also noticed the helper text labels had the editable-text cursor over them instead of the expected default cursor, so I added a line to the body{} section of the CSS to make sure it's always the default unless overridden by another class.

Hope that helps!

@TheoBr

This comment has been minimized.

Show comment
Hide comment
@TheoBr

TheoBr Dec 7, 2017

Owner

Perfect, thank you so much!

Owner

TheoBr commented Dec 7, 2017

Perfect, thank you so much!

@TheoBr TheoBr merged commit ca10f2e into TheoBr:master Dec 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment