New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale not recognized (in date format) (?) #27

Closed
ptar opened this Issue Dec 8, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@ptar

ptar commented Dec 8, 2016

EventtableEdit 4.5 is used in a Joomla with German language installed.
I use date fields formatted as "%d.%m.%Y (KW %V)"
For entries in 2017, I saw misaligned calender week numbers. The misalignment is by one week and fits to the the difference between American and ISO week numbers for 2017.
I added %B to the format pattern, but the month names are in English. So my assumption is, that the locale is not correctly recognized by EventTableEdit.

@Theophilix Theophilix added the bug label Dec 12, 2016

@Theophilix

This comment has been minimized.

Owner

Theophilix commented Dec 12, 2016

Thank you very much for reporting this bug. Any help in correcting this bug is apreciated.

@Theophilix

This comment has been minimized.

Owner

Theophilix commented Dec 23, 2016

Hello ptar,
please check again with this version: eventtableedit(21-12-2016).zip and tell if problem is solved.
Because I can't reproduce your error.

@ptar

This comment has been minimized.

ptar commented Jan 4, 2017

Hello Theophilix,
thanks for the provided version!
And maybe you can't reproduce the error, because I have to say "I'm sorry, my fault": Almost all of the dates in the events are on Sundays and Jan. 1st 2017 is the first Sunday, but in Week 52 (of 2016). So maybe - because I had to deal with the US/ISO missalignment lately - I was just assuming, that it was an error ("selbsterfüllende Prophezeiung").
Nevertheless, with "%d.%m.%Y (KW %V) %B", the %B results in "January", not "Januar".
But this could be a general misconfiguration (I got the Joomla installation about 4 months ago "as is" and it's only providing German content).
Do you have an idea how to easily check if the locale is correctly provided in the rest of Joomla? Thanks!

@Theophilix

This comment has been minimized.

Owner

Theophilix commented Jan 4, 2017

Thank you for your explanations. This is a bug. The locale can be defined via PHP: http://php.net/manual/de/function.setlocale.php. Check the follwing php file: %root%\site\helpers\etetable.php.
Solution: I will add a general LC_ALL setting and an additional locale - option to "style"-tab. But please be patient. This may take some weeks...

@Theophilix Theophilix closed this Jan 4, 2017

@Theophilix Theophilix reopened this Jan 4, 2017

@ptar

This comment has been minimized.

ptar commented Jan 12, 2017

Hello Theophilix,
thanks for fixing the locale bug!
And: I'll be patient :-)

@Theophilix

This comment has been minimized.

Owner

Theophilix commented Jan 24, 2017

Fixed with 4.4.3 version.

@Theophilix Theophilix closed this Jan 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment