Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend / Layout: give delete buttons it's own column, separate it from the change sort order column #49

Closed
Theophilix opened this Issue Apr 2, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@Theophilix
Copy link
Owner

Theophilix commented Apr 2, 2017

It does make sense to separate the delete cross from the duo-column "change sort order column" and give deleting function an own column. With this, the height of the grey box should be made flexible and the input field for the number could be made smaller in width (maybe half width).

Here it is necessary to:
a) create one more option in backend and rename them: "Add row sorting and deleting column" should be transformed into -> "Add row sorting column" + "add column to make rows deletable" / yes+no
b) add new rule in ACL and change old one. ("delete" + "reorder rows") works correctly
c) create one additional column for the red cross butttons
d) put the file cross.png in site folder because the file cross.png is in the admin folder. If the admin-folder is password protected, users can't change status of bolean value (cross or check mark). Therefor, we should move the file "cross.png" from admin to site folder.

@Theophilix

This comment has been minimized.

Copy link
Owner Author

Theophilix commented Apr 3, 2017

arguments for this discussion:
++if the user only wants to enable deleting function, the column for this is smaller than the actual one with double usage.
-- the additional column could lead to problems with layout views and need a good programming effort

@Theophilix Theophilix changed the title Seperate delete buttons from change sort order column Frontend / Layout: Seperate delete buttons from change sort order column Apr 7, 2017

@Theophilix Theophilix changed the title Frontend / Layout: Seperate delete buttons from change sort order column Frontend / Layout: give delete buttons it's own column, separate it from the change sort order column Oct 8, 2017

@Theophilix

This comment has been minimized.

Copy link
Owner Author

Theophilix commented Apr 6, 2018

Fixed in 4.6.3 version

@Theophilix Theophilix closed this Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.