Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows callback verification #22 #23

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Fix windows callback verification #22 #23

merged 4 commits into from
Nov 9, 2022

Conversation

Knupper
Copy link

@Knupper Knupper commented Nov 8, 2022 •
edited by ThexXTURBOXx
Loading

use _schemeRegExp not for windows platform
update url_launcher
add changelog
Fixes #22

use _schemeRegExp not for windows platform
7b466ea 
update url_launcher
add changelog
@Knupper Knupper changed the title Fix windows callback verification ([#22](https://github.com/ThexXTURBOXx/flutter_web_auth_2/issues/22)) Fix windows callback verification [#22] Nov 8, 2022
@Knupper Knupper changed the title Fix windows callback verification [#22] Fix windows callback verification [22] Nov 8, 2022
@Knupper Knupper changed the title Fix windows callback verification [22] Fix windows callback verification #22 Nov 8, 2022
@Knupper Knupper mentioned this pull request Nov 8, 2022
Closed
@Knupper Knupper changed the title Fix windows callback verification #22 DRAFT: Fix windows callback verification #22 Nov 8, 2022
@Knupper Knupper changed the title DRAFT: Fix windows callback verification #22 Fix windows callback verification #22 Nov 8, 2022
@ThexXTURBOXx
Copy link
Owner

I have pushed a commit to your branch. Could you please verify if that still works for you?
Using funcitonality from dart:io throws Exceptions on web.
This will now check the platform itself after confirming it is not web, but the assertion is still checked on every platform (in your fix, the assertion was only checked on web, not anymore on the other platforms)

Knupper
Knupper commented Nov 9, 2022
View reviewed changes
Copy link
Author

@Knupper Knupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested it with windows, iphone, android and mac and it works

flutter_web_auth_2/lib/flutter_web_auth_2.dart Show resolved Hide resolved
@ThexXTURBOXx ThexXTURBOXx merged commit efd6dbc into ThexXTURBOXx:master Nov 9, 2022
@ThexXTURBOXx
Copy link
Owner

2.0.2 has just been released! Thanks again for this PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThexXTURBOXx ThexXTURBOXx ThexXTURBOXx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows callbackUrlScheme are invalid
2 participants
@Knupper @ThexXTURBOXx