diff --git a/src/main/kotlin/app/revanced/patcher/resolver/MethodResolver.kt b/src/main/kotlin/app/revanced/patcher/resolver/MethodResolver.kt index c27a3fd6..187d9854 100644 --- a/src/main/kotlin/app/revanced/patcher/resolver/MethodResolver.kt +++ b/src/main/kotlin/app/revanced/patcher/resolver/MethodResolver.kt @@ -7,9 +7,7 @@ import app.revanced.patcher.cache.PatternScanData import app.revanced.patcher.signature.Signature import app.revanced.patcher.util.ExtraTypes import org.objectweb.asm.Type -import org.objectweb.asm.tree.ClassNode -import org.objectweb.asm.tree.InsnList -import org.objectweb.asm.tree.MethodNode +import org.objectweb.asm.tree.* private val logger = KotlinLogging.logger("MethodResolver") @@ -110,7 +108,7 @@ internal class MethodResolver(private val classList: List, private va } signature.opcodes?.let { _ -> - val result = method.instructions.scanFor(signature.opcodes) + val result = method.instructions.stripLabels().scanFor(signature.opcodes) if (!result.found) { logger.debug { "Comparing sig ${signature.name}: invalid opcode pattern" } return@cmp false to null @@ -123,13 +121,8 @@ internal class MethodResolver(private val classList: List, private va } } -private operator fun ClassNode.component1(): ClassNode { - return this -} - -private operator fun ClassNode.component2(): List { - return this.methods -} +private operator fun ClassNode.component1() = this +private operator fun ClassNode.component2() = this.methods private fun InsnList.scanFor(pattern: IntArray): ScanResult { for (i in 0 until this.size()) { @@ -157,3 +150,8 @@ private fun Type.convertObject(): Type { private fun Array.convertObjects(): Array { return this.map { it.convertObject() }.toTypedArray() } + +private fun InsnList.stripLabels(): InsnList { + this.removeAll { it is LabelNode || it is LineNumberNode } + return this +} diff --git a/src/test/kotlin/app/revanced/patcher/util/TestUtil.kt b/src/test/kotlin/app/revanced/patcher/util/TestUtil.kt index de9c831d..6d891e12 100644 --- a/src/test/kotlin/app/revanced/patcher/util/TestUtil.kt +++ b/src/test/kotlin/app/revanced/patcher/util/TestUtil.kt @@ -38,7 +38,8 @@ private class NodeStringBuilder { } override fun toString(): String { + if (sb.isEmpty()) return "" val s = sb.toString() - return s.substring(0 until s.length - 2) // remove the last ", " + return s.substring(0 .. (s.length - 2).coerceAtLeast(0)) // remove the last ", " } }