onDuplicate problem when there was no change in data

[Ettemlevest]

I'm using an insert statement with onDuplicate. If a user saves a data without anyy changes (record already in the database) the insert returns with bool(false) error. But there is no database error just 0 affected rows with the execution of the query.

Used code:

$data = [
    'id' => $id,
    'data_1' => $data_1,
    'data_2' => $data_2,
];

$db->onDuplicate(['data_1', 'data_2']);
if (!$db->insert('megbizasok_kamionok', $data))
    throw new DBException('json');

My problem is in the _buildInsert() function:

if ($stmt->affected_rows < 1) {
    return false;
}

Why is this considered an error when sql error number is 0?
Should I use a different approach?

[avbdr]

confirmed. ill work on a fix asap

[avbdr]

please test this patch

diff --git a/MysqliDb.php b/MysqliDb.php
index aa099b0..7f89fd9 100644
--- a/MysqliDb.php
+++ b/MysqliDb.php
@@ -1034,12 +1034,17 @@ class MysqliDb

         $this->_query = $operation . " " . implode(' ', $this->_queryOptions) . " INTO " . self::$prefix . $tableName;
         $stmt = $this->_buildQuery(null, $insertData);
-        $stmt->execute();
+        $status = $stmt->execute();
         $this->_stmtError = $stmt->error;
+        $haveOnDuplicate = !empty ($this->_updateColumns);
         $this->reset();
         $this->count = $stmt->affected_rows;

         if ($stmt->affected_rows < 1) {
+            // in case of onDuplicate() usage, if now rows were inserted
+            if ($status && $haveOnDuplicate) {
+                return true;
+            }
             return false;
         }

[avbdr]

have you had a chance to try the patch?

[Ettemlevest]

I'm really sorry for the late response I did not have any internet access in the last couple of weeks.
Just now I tested your patch it seems this solved this problem.

[avbdr]

thanks, ill commit that then