Wunderground url scheme change #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Squix78,
it's about the WundergroundClient again ;)
I added a second method updateConditions with a different signature to be able to use these ZMW-Codes Wunderground lately uses.
I also provide an example Sketch "WundergroundClientPlainDemo.ino" which simply uses the WundergroundClient and uses most of the public methods.
By the way: i didn't find out, how to use this methods appropriately:
because i can't figure out, how to retrieve the "period".
Why not adding a getter for the private field "currentForecastPeriod" or also providing the forecast getters without any parameters?
Beyond that i had some problems with getCurrentEpoch(). It seems to lead to a out-of-bound write in certain circumstances and crashed my esp8266. I will try to reproduce as soon as possible. Maybe the long is not long enough? ;)
But besides this, i would be very glad, You accepting my pull request again ;)
Yours,
Count023