Skip to content

Conversation

@pranavpadmasali
Copy link
Contributor

@pranavpadmasali pranavpadmasali commented Nov 20, 2025

Hi @rustybee42,

I was removing sleep statements in test cases and found out there was a test create file stripping api which had sleep 310 sec. This was because the file striping took more than 5 minutes to take effect. The test only passed when there was a sleep of over 300 seconds; otherwise, the expected number of targets differed from the actual targets used for striping.

In the meta code it looks like in the meta code waits for 5 min for the first pass. We never refresh the storage‑pool definitions once mgmtd finally knows about the targets.

With 7.4 version management we did not require this 300 sec sleep. So looks like we had to add this 5 min sleep in test case from 8.x release.

This PR implements notifications to refresh storage pools when stripping is changed, buddy groups or targets are deleted, ensuring pool membership remains consistent.

@pranavpadmasali pranavpadmasali requested a review from a team as a code owner November 20, 2025 12:33
@pranavpadmasali pranavpadmasali force-pushed the pranav/storage-pool-refresh branch 2 times, most recently from e6dcfb1 to 1b35a5c Compare November 20, 2025 12:51
Copy link
Collaborator

@rustybee42 rustybee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Although I don't like dumping out all these extra notifications when one could be enough if done properly.

But it should be fine for now as we can't break compatibility. Not really sure though if it could have unexpected side effects on the servers.

@pranavpadmasali pranavpadmasali force-pushed the pranav/storage-pool-refresh branch from df7d059 to 46d8aca Compare November 26, 2025 10:16
@pranavpadmasali pranavpadmasali merged commit a894f3d into main Nov 26, 2025
4 checks passed
@pranavpadmasali pranavpadmasali deleted the pranav/storage-pool-refresh branch November 26, 2025 10:26
@iamjoemccormick iamjoemccormick added the bug Something isn't working label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants