New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate golem::add_ui_server_files() #445
Comments
Might be needed for #693 |
I am using this function quite a bit! |
Hey @EwokOzwok, would you be ok with adding some details on when / how you're using it? thanks |
@ColinFay I'm using it to modify golem packages for PWA compatibility with shinyMobile: Open ./R/app_ui.R. Source: Slide: Road to PWA : Modify {golem} package Although the deeper I go, the more trouble I'm having getting shinyMobile's PWA to work in deployed docker containers. But if it's necessary to call this function to modify golem to be PWA compatible with shinyMobile I'd keep using it! p.s. I'm not an expert if that wasn't abundantly clear :) |
I don't think we should keep
golem::add_ui_server_files()
inside{golem}
.This issue is a proposal for softly deprecating it in the next release.
Please comment below if you're using this function and are against deprecating this function.
The text was updated successfully, but these errors were encountered: