CSS madness: Bottoms of help buttons getting cut off #1320

Closed
ginatrapani opened this Issue Apr 17, 2012 · 4 comments

Comments

Projects
None yet
3 participants
Owner

ginatrapani commented Apr 17, 2012

Ever since @anildash's recent CSS changes in 9c06218 and after the fix in 858bc8e , we're still seeing lots of alerts and headers cutting off messages and buttons.

Screenshot

anildash was assigned Apr 17, 2012

@ginatrapani ginatrapani added a commit that referenced this issue Apr 19, 2012

@ginatrapani ginatrapani Fix alert min-height; convert tabs to spaces
Partially addresses #1320
6479797
Contributor

dainmiller commented Dec 21, 2012

Hey Gina,

I am seeing that most of these issues have been fixed, but this one still persists:

Screen Shot 2012-12-20 at 9 51 44 PM

I have a fix for it in the works, if you'd like me to issue a pull just let me know. The reason I ask that is perhaps we left that help button down a bit as a compromise to other issues? Or should we just go ahead and fix that?

Running latest version on Mac 10.8/Chrome/Normal zoom level.

Owner

ginatrapani commented Dec 21, 2012

I'd love a pull request to fix this issue, thx @cdainmiller

Contributor

dainmiller commented Dec 21, 2012

No problem. I went ahead and sent in the pull request, but I also noticed a few other things.

There are a lot of inline styles in the HTML/templating layer. I understand why it is done, as it is quick to use and test things out - but it should be abstracted when a commit happens (at least, in my opinion). In larger projects it can be harder to abstract due to naming issues, but we can use CSS psudo-selectors to help us with this. And all while remaining battle hardened for all old browsers by not going too far down the psudo-selector rabbit hole. So if you don't mind I'd like to keep working on the CSS and clean up some of this as well.

Oh, and to catch up (sorry, it's been a bit of a crazy past few months for me), did you happen to find a good way to implement a JavaScript testing framework into Travis CI? My lack of experience with Travis CI (although some, not much) really stunted my search for what would be the best testing framework to use. We are still actively using Jasmine at my day job, and I have come to grow quite fond of it. The answer I'm getting from everyone is http://docs.busterjs.org/en/latest/, because mainly it offers the terminal node testing, browser testing, and also Travis CI integration. Though, it is still in a heavily instable state so I am trepidatious about that choice. I will keep looking around but would love to hear any thought you may have.

Owner

ginatrapani commented Dec 21, 2012

On Thu, Dec 20, 2012 at 11:15 PM, Dain Miller notifications@github.comwrote:

There are a lot of inline styles in the HTML/templating layer. I
understand why it is done, as it is quick to use and test things out - but
it should be abstracted when a commit happens (at least, in my opinion). In
larger projects it can be harder to abstract due to naming issues, but we
can use CSS psudo-selectors to help us with this. And all while remaining
battle hardened for all old browsers by not going too far down the
psudo-selector rabbit hole. So if you don't mind I'd like to keep working
on the CSS and clean up some of this as well.

There is an embarrassing amount of inline styles and those should be
cleaned up. But right now we're hard at work on version 2.0, which is
Bootstrap-based with much cleaner markup. A first beta will be released on
Jan 1st or second. The working branch is currently here (I'll probably
rename this to something like 2.0 soon):

https://github.com/ginatrapani/ThinkUp/tree/1319-insights-feed-pluggable

A working demo installation:

http://ginatrapani.thinkupapp.com/

@suth is doing most of the CSS work on it. So it seems like a waste of
effort to clean up the old 1.0 code. Might as well focus on the new
version, as the old styles will be deprecated.

Oh, and to catch up (sorry, it's been a bit of a crazy past few months for

me), did you happen to find a good way to implement a JavaScript testing
framework into Travis CI?

Sadly I haven't, I've been so caught up with 2.0 work I haven't had time to
pursue it. I do want Travis integration but I'd rather not use something
unstable. If you're comfortable with Jasmine, it looks like Travis can run
headless browser Jasmine tests:

http://about.travis-ci.org/docs/user/gui-and-headless-browsers/

http://ginatrapani.org

@anildash anildash added a commit to anildash/ThinkUp that referenced this issue Jan 7, 2013

@anildash Dain Miller + anildash Issue #1320: Added a bit of relative positioning to fix the help butt…
…on alignment on (login/register/forgot password) pages.
d0fc756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment