Specify icon name in insight template #1462

Closed
ginatrapani opened this Issue Jan 21, 2013 · 0 comments

Comments

Projects
None yet
1 participant
Owner

ginatrapani commented Jan 21, 2013

Right now the insight templates use outdated and limited logic to display insight icons, something like:

<i class="icon-white icon-{if $i->emphasis eq '1'}time{elseif $i->emphasis eq '2'}thumbs-up{elseif $i->emphasis eq '3'}warning-sign{else}star{/if}"></i>

Not only should the icon not depend on insight emphasis, there are tons of other glyphs available for use. The full list is here:
http://twitter.github.com/bootstrap/base-css.html#icons

We need to modify the insight tpl files to define what icon an insight should use on an insight basis.

@anildash anildash added a commit to anildash/ThinkUp that referenced this issue Jan 28, 2013

@ginatrapani @anildash ginatrapani + anildash Customize insight icons, closes #1462 81b9bed

@anildash anildash added a commit to anildash/ThinkUp that referenced this issue Jan 28, 2013

@ginatrapani @anildash ginatrapani + anildash Customize insight icons, closes #1462 7ac2ad9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment