Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Initial ".@username" should be link-converted #373

Closed
su opened this Issue Oct 9, 2010 · 5 comments

Comments

Projects
None yet
4 participants

su commented Oct 9, 2010

If a Twitter update starts with .@whatever (to get around Twitter's reply visibility limitation), TU doesn't capture and link the username

finn commented Nov 1, 2010

Is there some sort of official document on twitter's dev site or elsewhere which details the proper regexp or pattern for capturing legal twitter usernames?

finn commented Nov 1, 2010

Discussion of Twitter text libs here:

http://engineering.twitter.com/2010/02/introducing-open-source-twitter-text.html

From a brief readthrough it looks like the best thing to do would be to rely on the Twitter-supplied PHP and text conformance. Here and here:

http://github.com/mzsanford/twitter-text-php
http://github.com/mzsanford/twitter-text-conformance

Owner

ginatrapani commented Nov 1, 2010

Cleaning up this comment thread, GitHub got weird. Latest PHP library for linkyifying tweets is here:
http://github.com/ngnpope/twitter-text-php

Contributor

suth commented Jan 9, 2011

Fixed Twitter username link bugs

  • Doesn't link isolated @ symbols
  • Fixed links to usernames surrounded by parentheses
  • Fixed links to usernames starting with a .
  • Simplified the replacement of usernames using a regex
  • Added test cases for each to assert links are correct
  • Closed by 33f9831, Closed by 33f9831, Closed by 33f9831, Closed by 33f9831, Closed by 33f9831

unruthless pushed a commit to unruthless/ThinkUp that referenced this issue Apr 27, 2011

Fixed Twitter username link bugs
* Doesn't link isolated @ symbols
* Fixed links to usernames surrounded by parentheses
* Fixed links to usernames starting with a .
* Simplified the replacement of usernames using a regex
* Added test cases for each to assert links are correct
* Closes #373, Closes #374, Closes #375, Closes #381, Closes #543

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment