Improve Twitter username linking method #381

Closed
su opened this Issue Oct 10, 2010 · 1 comment

Comments

Projects
None yet
2 participants

su commented Oct 10, 2010

This issue just to capture the TODO comment in

http://github.com/ginatrapani/ThinkUp/blob/master/webapp/_lib/view/plugins/modifier.link_usernames.php
http://github.com/ginatrapani/ThinkUp/blob/master/webapp/_lib/view/plugins/modifier.link_usernames_to_twitter.php

//TODO: Find a more elegant way to do this that's totally regex-based, not loving this explod/implode approach

Contributor

suth commented Jan 9, 2011

Fixed Twitter username link bugs

  • Doesn't link isolated @ symbols
  • Fixed links to usernames surrounded by parentheses
  • Fixed links to usernames starting with a .
  • Simplified the replacement of usernames using a regex
  • Added test cases for each to assert links are correct
  • Closed by 33f9831, Closed by 33f9831, Closed by 33f9831, Closed by 33f9831, Closed by 33f9831

unruthless pushed a commit to unruthless/ThinkUp that referenced this issue Apr 27, 2011

Fixed Twitter username link bugs
* Doesn't link isolated @ symbols
* Fixed links to usernames surrounded by parentheses
* Fixed links to usernames starting with a .
* Simplified the replacement of usernames using a regex
* Added test cases for each to assert links are correct
* Closes #373, Closes #374, Closes #375, Closes #381, Closes #543

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment