Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

TestOfSmartyModiferLinkUsernames needs to use 'site_root_path' cfg val #558

amygdala opened this Issue Jan 17, 2011 · 1 comment


None yet
2 participants

amygdala commented Jan 17, 2011

For TestOfSmartyModiferLinkUsernames to pass for me, I need to change the code starting at line 61 to the following, which uses the site_root_path:

    $this->internally_linked_tweets = array(
    'Hey <a href="' . $config->getValue('site_root_path') .
    'user/?u=anildash&n=twitter&i=me">@anildash</a> think this up!', 
    "If you're interested, @ me details", 
    '.<a href="' . $config->getValue('site_root_path') .'user/?u=anildash&n=twitter&i=me">@anildash</a> thinks so',
    'This is a tweet with multiple usernames like <a href="' . $config->getValue('site_root_path') . 
    'user/?u=waxpancake&n=twitter&i=me">@waxpancake</a> '.
    'and <a href="' . $config->getValue('site_root_path') . 'user/?u=thinkupapp&n=twitter&i=me">@thinkupapp</a>',
    'Blah blah blah (<a href="' . $config->getValue('site_root_path') . 
    'user/?u=username&n=twitter&i=me">@username</a>). Blah blah');

I suspect I may be the only runner of tests who will trip over this, so it's not a big deal.
I'll fold this change into an ongoing branch of mine if it does not get addressed otherwise.


ginatrapani commented Jan 25, 2011

Fixed bad assertion in TestOfSmartyModifierLinkUsernames

@unruthless unruthless pushed a commit to unruthless/ThinkUp that referenced this issue Apr 27, 2011

@ginatrapani ginatrapani Fixed bad assertion in TestOfSmartyModifierLinkUsernames
* Closes #558

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment