Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI review changes #1071

Closed
wants to merge 9 commits into from

Conversation

waxpancake
Copy link
Contributor

As promised, every change from our UI review that was scoped for 1.0, plus a couple more

@ginatrapani
Copy link
Member

[AUTOMATED TEST RUN NOTIFICATION]
Hi! Thanks for submitting a pull request to ThinkUp.
This is an automated test run of the code in your pull request branch. If there are test failures, please close the request, resolve the failures, and re-submit.
If you need help debugging the test failures, get in touch on the ThinkUp developer mailing list:

http://groups.google.com/a/expertlabs.org/group/thinkup-dev

Thanks for your contribution and help maintaining ThinkUp,
Gina

TEST RESULTS:

Model tests

OK
Test cases run: 52/52, Passes: 3169, Failures: 0, Exceptions: 0
Plugin tests

  1. Pattern [/Set the Web Site > Site URL to
    https:///] not detected in [String: 

Facebook Plugin

...] at [/Users/gina/Sites/thinkup/webapp/plugins/facebook/tests/TestOfFacebookPluginConfigurationController.php line 206]
in testConfigOptionsIsAdminWithSSL
in TestOfFacebookPluginConfigurationController
2) Pattern [/Set the callback URL to

https:///] not detected in [String: 

Twitter Plugin

<p...] at [/Users/gina/Sites/thinkup/webapp/plugins/twitter/tests/TestOfTwitterPluginConfigurationController.php line 199]
in testConfigOptionsIsAdminWithSSL
in TestOfTwitterPluginConfigurationController
FAILURES!!!
Test cases run: 32/32, Passes: 1324, Failures: 2, Exceptions: 0
Integration tests
OK
Test cases run: 11/11, Passes: 188, Failures: 0, Exceptions: 0
Installer tests
OK
Test cases run: 2/2, Passes: 2172, Failures: 0, Exceptions: 0
Controller tests
OK
Test cases run: 35/35, Passes: 1861, Failures: 0, Exceptions: 0

Total ThinkUp test passes: 8714
Total ThinkUp test failures: 2
Time elapsed: 11 minute(s)

37054 total words of application documentation

@ginatrapani
Copy link
Member

I'll fix these failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants