Add ability to add domains as facebook instances #1088

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@cwarden
Contributor

cwarden commented Oct 31, 2011

  • Facebook Insights data can be recorded for domains: likes and like
    button impressions are recorded
  • Facebook domain instances have a different dashboard than user and
    page instances; there's just one dashboard for now
  • Google Chart Tools is used for visualization so this depends on issue
    #1068 being merged first
  • Add a customDefaultDashboardModules method to the DashboardPlugin interface
    to optionally add additional modules the default dashboard for an
    instance. Modules are defined as MenuItems containing Datasets.
  • Add Domain Metrics module to default dashboard for facebook domain instances.

cwarden added some commits Oct 28, 2011

Use timezone instead of UTC offset if possible
Set the time_zone session variable in MySQL to a timezone, e.g.
America/Los_Angeles, instead of the current offset.  This fixes
conversion from/to UTC for times that are in a different offset.

For example, on 2011-10-28, Los Angeles is -07:00 because it is daylight
saving time.  If you store 2011-01-01 00:00:00 into a TIMESTAMP field
when your time_zone session variable is set to '-07:00', the time will
be stored as 2011-01-01 07:00:00 UTC instead of 2011-01-01 08:00:00,
which will be used if your time_zone variable is set to
'America/Los_Angeles'.

Using timezones instead of offsets requires that the MySQL timezone
tables be populated.  See mysql_tzinfo_to_sql(1).  If a timezone can't
be used, fall back to using an offset.
Add ability to add domains as facebook instances
- Facebook Insights data can be recorded for domains: likes and like
  button impressions are recorded

- Facebook domain instances have a different dashboard than user and
  page instances; there's just one dashboard for now

- Google Chart Tools is used for visualization so this depends on issue
  #1068 being merged first
Custom default dashboards through modules
- Add a customDefaultDashboardModules method to the DashboardPlugin interface
to optionally add additional modules the default dashboard for an
instance.  Modules are defined as MenuItems containing Datasets.

- Add Domain Metrics module to default dashboard for facebook domain instances.

- Add customDefaultDashboardModules methods to Google+ and Twitter
  plugins to be compatible with updated DashboardPlugin Interface

- Remove parameters from phpdocs for loadDefaultDashboard.
@ginatrapani

This comment has been minimized.

Show comment Hide comment
@ginatrapani

ginatrapani Nov 2, 2011

Owner

Once @waxpancake is able to dive into #1068 and get it ready, I'll review this one.

Owner

ginatrapani commented Nov 2, 2011

Once @waxpancake is able to dive into #1068 and get it ready, I'll review this one.

@ginatrapani

This comment has been minimized.

Show comment Hide comment
@ginatrapani

ginatrapani Mar 2, 2012

Owner

Alright, now that we've got #1068 merged, I can take a look at this one. I'm booked today, so I'll get to it early next week. Thanks again for your patience @cwarden.

Owner

ginatrapani commented Mar 2, 2012

Alright, now that we've got #1068 merged, I can take a look at this one. I'm booked today, so I'll get to it early next week. Thanks again for your patience @cwarden.

@ginatrapani

This comment has been minimized.

Show comment Hide comment
@ginatrapani

ginatrapani Feb 18, 2013

Owner

Christian it's taken me a year to admit this, but I'm hoping it's better late than never: this pull request isn't going to make it in. The app has changed so drastically since you first sent it, and rather than try to rebase and resolve all the conflicts and modernize everything from this state, instead let's start fresh and think through how this functionality would work in the new 2.0 stream versus the old dashboard.

I feel terrible to have wasted your efforts. I hope you'll accept my apology putting this off so long and letting things diverge so much.

Owner

ginatrapani commented Feb 18, 2013

Christian it's taken me a year to admit this, but I'm hoping it's better late than never: this pull request isn't going to make it in. The app has changed so drastically since you first sent it, and rather than try to rebase and resolve all the conflicts and modernize everything from this state, instead let's start fresh and think through how this functionality would work in the new 2.0 stream versus the old dashboard.

I feel terrible to have wasted your efforts. I hope you'll accept my apology putting this off so long and letting things diverge so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment