Skip to content

Fixed Issue #959. Added preferences to config file to allow explicitly s...#1139

Closed
thegeekiestmark wants to merge 1 commit into
ThinkUpLLC:masterfrom
thegeekiestmark:959-configurable-temp-dir-RC1
Closed

Fixed Issue #959. Added preferences to config file to allow explicitly s...#1139
thegeekiestmark wants to merge 1 commit into
ThinkUpLLC:masterfrom
thegeekiestmark:959-configurable-temp-dir-RC1

Conversation

@thegeekiestmark

Copy link
Copy Markdown
Contributor

...etting cache and compiled directories. Also fixed tests to allow for a configurable cache dir, and added an example to the sample config file to show how it can be set to the system's temp dir. Please let me know if you have any further questions or concerns. Thanks!

@thegeekiestmark

Copy link
Copy Markdown
Contributor Author

Something I just noticed. It appears that the upgrade token gets written to _lib/view/compiled_view by default, even if another temp directory is set. I'm looking into this right now ...

@ginatrapani

Copy link
Copy Markdown
Member

Hi Mark--I put off code-reviewing this b/c it sounds like there's still more to do, but in the meantime @pushingit also tackled this issue in #1185, so I'm going to review that one. I'll let you know if it looks like that one's complete.

@ginatrapani ginatrapani closed this Dec 2, 2011
@thegeekiestmark

Copy link
Copy Markdown
Contributor Author

Hi, Gina:

Thanks for the update. I recall seeing those notes on GitHub. If her/his
solution is better than mine, go ahead and use it - my ego won't be hurt :)

Mark

On Thu, Dec 1, 2011 at 4:41 PM, Gina Trapani <
reply@reply.github.com

wrote:

Hi Mark--I put off code-reviewing this b/c it sounds like there's still
more to do, but in the meantime @pushingit also tackled this issue in
#1185, so I'm going to review that one. I'll let you know if it looks like
that one's complete.


Reply to this email directly or view it on GitHub:
#1139 (comment)

Regards,

Mark Linford
http://www.marklinford.com/
http://twitter.com/thegeekiestmarkhttp://www.google.com/profiles/thegeekiestmarkhttp://www.linkedin.com/in/mlinfordhttp://www.flickr.com/photos/mlinford/http://identi.ca/thegeekiestmark/http://www.delicious.com/kry10http://www.facebook.com/geekymark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants