Added date ranges for some API calls #1378

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

danipena commented Sep 10, 2012

API date range calls for: user_mentions, user_questions, user_replies and
post replies.

Following up on your comments from (ginatrapani#1376):

  • Cleaned up code formatting n' stuff.
  • Contains appropriate tests and documentation for the added calls.
  • Code is pretty straightforward and tries to follow existing style.

API calls do not have a configurable count limit, following up on the
philosophy for the other range calls. Documentation has been tweaked
to reflect this.

Please let me know if all is correct and if it's OK to do the pull request
on your master. Used latest code this time =)

Thanks!

Powered by Televisió de Catalunya - SOCIALMEDIA PROJECT - CEN-20101037 - This contribution has been kindly sponsored by the Centro para el Desarrollo Tecnológico Industrial within the Programa de Investigación Nacional Español CENIT. - http://www.cenitsocialmedia.es/

@danipena danipena Added date ranges for some API calls
API date range calls for: user_mentions, user_questions, user_replies and
post replies.

Cleaned up code formatting n' stuff. Contains appropriate tests and
documentation for the added calls. Code is pretty straightforward.

API calls do not have a configurable count limit, following up on the
philosophy for the other range calls. Documentation has been tweaked
to reflect this.
5b3e0ed
Contributor

danipena commented Sep 10, 2012

Oh, and thanks to @danigiri for the code review and the documentation tweaks!

No problem =)

Owner

ginatrapani commented Sep 17, 2012

Great news, TestOfPostAPIController is now completely passing for me. Now we're just missing tests for the new functions in PostMySQLDAO. Once we have tests for getRepliesToPostInRange and getAllMentionsInRange and getAllRepliesInRange, I can merge this. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment