Tests of the added date ranges for some API calls #1389

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet
4 participants
@danipena
Contributor

danipena commented Sep 26, 2012

Tests of API date range calls for: user_mentions, user_questions, user_replies and post_replies.

Following up on your comments from (ginatrapani#1378)

  • Contains the tests that were not included for the added calls in the previous pull request on 'tests/PostMySQLDAO'.
  • Code is pretty straightforward and tries to follow existing style.

Please let me know if all is correct.

Thanks!

Powered by Televisió de Catalunya - SOCIALMEDIA PROJECT - CEN-20101037 - This contribution has been kindly sponsored by the Centro para el Desarrollo Tecnológico Industrial within the Programa de Investigación Nacional Español CENIT. - http://www.cenitsocialmedia.es/

danipena and others added some commits Sep 10, 2012

Added date ranges for some API calls
API date range calls for: user_mentions, user_questions, user_replies and
post replies.

Cleaned up code formatting n' stuff. Contains appropriate tests and
documentation for the added calls. Code is pretty straightforward.

API calls do not have a configurable count limit, following up on the
philosophy for the other range calls. Documentation has been tweaked
to reflect this.
Fix "1103 Incorrect table name" error
Fixed problem where the database update/migration would fail on databases that don't allow periods in table names. Discussion: #1377
Cleaned up first two JavaScript files. Added missing semi-colons and …
…added != where should have been !== in only two cases. No other changes were made to code.
Merge branch 'master' of https://github.com/ginatrapani/ThinkUp
Download the newest version of ThinkUp to local
Tests of the added date ranges for some API calls
Tests of API date range calls for: user_mentions, user_questions, user_replies and post_replies.

Following up on your comments from (#1378)

* Contains the tests for the added calls that were not included in the previous pull request on 'tests/PostMySQLDAO'.
* Code is pretty straightforward and tries to follow existing style.

Please let me know if all is correct.

Thanks!

Powered by Televisi� de Catalunya - SOCIALMEDIA PROJECT - CEN-20101037 - This contribution has been kindly sponsored by the Centro para el Desarrollo Tecnol�gico Industrial within the Programa de Investigaci�n Nacional Espa�ol CENIT. - http://www.cenitsocialmedia.es/
Tests of the added date ranges for some API calls
Tests of API date range calls for: user_mentions, user_questions, user_replies and post_replies.

Following up on your comments from (#1378)

Contains the tests that were not included for the added calls in the previous pull request on 'tests/PostMySQLDAO'.
Code is pretty straightforward and tries to follow existing style.

Please let me know if all is correct.

Thanks!

Powered by Televisi� de Catalunya - SOCIALMEDIA PROJECT - CEN-20101037 - This contribution has been kindly sponsored by the Centro para el Desarrollo Tecnol�gico Industrial within the Programa de Investigaci�n Nacional Espa�ol CENIT. - http://www.cenitsocialmedia.es/
@danipena

This comment has been minimized.

Show comment Hide comment
@danipena

danipena Oct 15, 2012

Contributor

Hi Gina,

Do you need anything else where I could help you on this API methods? I am ready to keep on working and contributing to ThinkUp!

Best wishes,

Dani

Contributor

danipena commented Oct 15, 2012

Hi Gina,

Do you need anything else where I could help you on this API methods? I am ready to keep on working and contributing to ThinkUp!

Best wishes,

Dani

@ginatrapani

This comment has been minimized.

Show comment Hide comment
@ginatrapani

ginatrapani Oct 19, 2012

Owner

Hi Dani--apologies for the delay, my daughter was born a few weeks ago so I've been slow to handle incoming pull requests.

Looks like all your tests are complete and passing, which is wonderful. I will merge this into master.

Before I do, I did have to do some cleanup and corrections. In the future, some guidelines to keep in mind when you're working on ThinkUp code:

I fixed that in 50da8fc

We appreciate all the work you've done on this. Thanks!

Owner

ginatrapani commented Oct 19, 2012

Hi Dani--apologies for the delay, my daughter was born a few weeks ago so I've been slow to handle incoming pull requests.

Looks like all your tests are complete and passing, which is wonderful. I will merge this into master.

Before I do, I did have to do some cleanup and corrections. In the future, some guidelines to keep in mind when you're working on ThinkUp code:

I fixed that in 50da8fc

We appreciate all the work you've done on this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment